Fix dropdown not opening on overriden selected-option slots (#790) #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though #869 is open it seems to be a larger change, and as far as I can tell it's not really fixed, the only commit is a cleanup of toggleDropdown. Since the issue is tagged "help-wanted" anyway, I'm opening this
This fix (for #790) is fairly simple, instead of checking for vs__selected we check whether the target is a child node of the selectedOptions ref. I then realized that with this, clicking the deselect button would open the dropdown, which felt a bit weird, so I added the bit of extra logic to exclude those.