Merge SPC into SSC #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishchandr70
requested review from
luckychess,
bogdan-alexandrescu,
emanuelconunaemme,
rkollar and
lukitsbrian
rkollar
requested changes
Jul 3, 2024
| types.RegisterQueryServer(cfg.QueryServer(), am.keeper) | ||
|
|
||
| m := keeper.NewMigrator(am.keeper, am.legacySubspace) | ||
| err := cfg.RegisterMigration(types.ModuleName, 1, m.Migrate1to2) |
There was a problem hiding this comment.
There should not be any migrations yet. Maybe just leave one of them (1to2) and commented out.
| } | ||
|
|
||
| // ConsensusVersion is a sequence number for state-breaking change of the module. It should be incremented on each consensus-breaking change introduced by the module. To avoid wrong/empty versions, the initial version should be set to 1 | ||
| func (AppModule) ConsensusVersion() uint64 { return 3 } |
There was a problem hiding this comment.
Should be 1 in all the added modules from SPC.
| @@ -0,0 +1,164 @@ | |||
| package chainlet | |||
There was a problem hiding this comment.
Both migrations packages should also be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the SPC code into SSC including components concerned with cross chain validation (CCV).
It has been tested in a local dev environment using a single validator
SSCDand a single validatorsagaosdconnected using ago relayer.For local testing, please ping me.