Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course grading dialog #2718

Closed
wants to merge 241 commits into from
Closed

Course grading dialog #2718

wants to merge 241 commits into from

Conversation

haraldschilly
Copy link
Contributor

First step towards "assisted" grading. The most fundamental idea is to assign points to files (later, also automatically via some magic™) . Everything syncs as usual, which is pretty neat.

The most important aspect to review is the structure of the course file. It's modeled closely how grades are done. But additionally, there is a mapping from each file path in the collected files of the respective student to an integer (the points), and defaults to zero → see course/actions::set_points.

@haraldschilly haraldschilly force-pushed the course-grading-manual branch 2 times, most recently from 4f75c0b to 89db7a8 Compare February 23, 2018 21:12
@haraldschilly
Copy link
Contributor Author

This pull request introduces 14 alerts when merging 9c2f2dd into 20c6847 - view on LGTM.com

new alerts:

  • 11 for Useless assignment to local variable
  • 1 for Unreachable statement
  • 1 for Useless conditional
  • 1 for Unbound event handler receiver

Comment posted by LGTM.com

@haraldschilly
Copy link
Contributor Author

This pull request introduces 14 alerts when merging d312749 into 02bfc1e - view on LGTM.com

new alerts:

  • 11 for Useless assignment to local variable
  • 1 for Unreachable statement
  • 1 for Useless conditional
  • 1 for Unbound event handler receiver

Comment posted by LGTM.com

@haraldschilly
Copy link
Contributor Author

This pull request introduces 14 alerts when merging 640a300 into d989b58 - view on LGTM.com

new alerts:

  • 11 for Useless assignment to local variable
  • 1 for Unreachable statement
  • 1 for Useless conditional
  • 1 for Unbound event handler receiver

Comment posted by LGTM.com

@haraldschilly
Copy link
Contributor Author

This pull request introduces 14 alerts when merging 27fd758 into 077c2c6 - view on LGTM.com

new alerts:

  • 11 for Useless assignment to local variable
  • 1 for Unreachable statement
  • 1 for Useless conditional
  • 1 for Unbound event handler receiver

Comment posted by LGTM.com

@haraldschilly
Copy link
Contributor Author

This pull request introduces 1 alert when merging fcb3d52 into 077c2c6 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@haraldschilly
Copy link
Contributor Author

This pull request introduces 1 alert when merging 3d5c086 into a4304fe - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Comment posted by LGTM.com

@williamstein
Copy link
Contributor

Closing due to being stale for long, merge conflicts, and probably something more tightly integrated with courses and annotation may be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-help I could really use help on this from somebody else! PR-needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants