-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pycares.Channel's default should be None, not -1 #59
Comments
Sounds reasonable, I'd take a patch if you're up for it :-) |
Kentzo
added a commit
to GreatFruitOmsk/pycares
that referenced
this issue
Dec 12, 2017
boytm
added a commit
to boytm/pycares
that referenced
this issue
Mar 9, 2018
boytm
added a commit
to boytm/pycares
that referenced
this issue
Apr 5, 2018
Fixed in #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's unusual to use
-1
as a placeholder for default value. Code that wraps pycares has to either explicitly mapNone
to-1
or expose-1
as a default value. Given thatNone
is widely used, mapping is likely inevitable.Instead, implementation should be adjusted to allow None as a "use default" placeholder along with
-1
for backward compatibility.The text was updated successfully, but these errors were encountered: