Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycares.Channel's default should be None, not -1 #59

Closed
Kentzo opened this issue Nov 10, 2017 · 2 comments
Closed

pycares.Channel's default should be None, not -1 #59

Kentzo opened this issue Nov 10, 2017 · 2 comments

Comments

@Kentzo
Copy link

Kentzo commented Nov 10, 2017

It's unusual to use -1 as a placeholder for default value. Code that wraps pycares has to either explicitly map None to -1 or expose -1 as a default value. Given that None is widely used, mapping is likely inevitable.

Instead, implementation should be adjusted to allow None as a "use default" placeholder along with -1 for backward compatibility.

@saghul
Copy link
Owner

saghul commented Dec 11, 2017

Sounds reasonable, I'd take a patch if you're up for it :-)

@saghul
Copy link
Owner

saghul commented Jan 16, 2019

Fixed in #83

@saghul saghul closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants