Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setTimeout: support second params optional #283

Merged
merged 1 commit into from Apr 27, 2022
Merged

setTimeout: support second params optional #283

merged 1 commit into from Apr 27, 2022

Conversation

Sxs7513
Copy link
Contributor

@Sxs7513 Sxs7513 commented Apr 25, 2022

when js do not pass sencond params into setTimeout, the program will crash

setTimeout(() => { //do something })

other platform like nodejs，web browser all support second params optional

saghul
saghul approved these changes Apr 25, 2022
View reviewed changes
Copy link
Owner

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Sxs7513
Copy link
Contributor Author

Sxs7513 commented Apr 27, 2022

Thank you!

Hi! When wiil it be merged?

@saghul saghul merged commit 43ee1f2 into saghul:master Apr 27, 2022
@saghul
Copy link
Owner

saghul commented Apr 27, 2022

Oops, forgot to press the button :-) It's merged now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sxs7513 @saghul