use #[non_exhaustive] instead of Unknown

[EverlastingBugstopper]

Features Description
instead of having an Unknown variant for types::Vendor, make it #[non_exhaustive] so it's possible to add other variants over time without breaking changes for folks consuming this library.

Current code Sample

pub enum Vendor {
    AppCenter,
    AppVeyor,
    AzurePipelines,
    Bamboo,
    BitbucketPipelines,
    Bitrise,
    Buddy,
    Buildkite,
    CircleCI,
    CirrusCI,
    AWSCodeBuild,
    Codeship,
    Drone,
    DSARI,
    GitLabCI,
    GitHubActions,
    GoCD,
    Heroku,
    Hudson,
    Jenkins,
    MagnumCI,
    NetlifyCI,
    Nevercode,
    Render,
    SailCI,
    Screwdriver,
    Semaphore,
    Shippable,
    SolanoCI,
    StriderCD,
    TaskCluster,
    TeamCity,
    TravisCI,
    ZEITNow,
    Unknown,
}

Proposed code Sample

#[non_exhaustive]
pub enum Vendor {
    AppCenter,
    AppVeyor,
    AzurePipelines,
    Bamboo,
    BitbucketPipelines,
    Bitrise,
    Buddy,
    Buildkite,
    CircleCI,
    CirrusCI,
    AWSCodeBuild,
    Codeship,
    Drone,
    DSARI,
    GitLabCI,
    GitHubActions,
    GoCD,
    Heroku,
    Hudson,
    Jenkins,
    MagnumCI,
    NetlifyCI,
    Nevercode,
    Render,
    SailCI,
    Screwdriver,
    Semaphore,
    Shippable,
    SolanoCI,
    StriderCD,
    TaskCluster,
    TeamCity,
    TravisCI,
    ZEITNow,
}

[sagiegurari]

good idea. I will take care of it.
thanks a lot for the feedback

[sagiegurari]

the unknown should stay however, because it means i detect its CI env, but cant tell which.

[EverlastingBugstopper]

i'd argue that the Option tells you if it detects it as a CI env, and adding non_exhaustive means consumers would handle the _ case and that would count as "detecting as CI env but not sure which one it is".

[sagiegurari]

ya, as lib consumer. but as provider i need to provide some value.

[EverlastingBugstopper]

oohhh i see. that makes sense! carry on 😄

[sagiegurari]

released. thanks a lot.