Skip to content

Commit

Permalink
upgrade markdownlint
Browse files Browse the repository at this point in the history
  • Loading branch information
@sagiegurari
sagiegurari committed May 14, 2018
1 parent 54f3458 commit 2672f2b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ See [contributing guide](.github/CONTRIBUTING.md)

| Date | Version | Description |
| ----------- | ------- | ----------- |
| 2018-04-30 | v1.1.4 | Maintenance |
| 2018-05-14 | v1.1.5 | Maintenance |
| 2018-04-21 | v1.1.3 | Upgrade markdownlint version |
| 2016-11-04 | v1.0.11 | Support new markdownlint 0.3.0 options |
| 2016-07-01 | v0.1.0 | Updated task config to use options |
Expand Down
2 changes: 1 addition & 1 deletion docs/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
| Date | Version | Description |
| ----------- | ------- | ----------- |
| 2018-04-30 | v1.1.4 | Maintenance |
| 2018-05-14 | v1.1.5 | Maintenance |
| 2018-04-21 | v1.1.3 | Upgrade markdownlint version |
| 2016-11-04 | v1.0.11 | Support new markdownlint 0.3.0 options |
| 2016-07-01 | v0.1.0 | Updated task config to use options |
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "grunt-markdownlint",
"version": "1.1.4",
"version": "1.1.5",
"description": "A grunt task for markdown style checker and lint tool.",
"author": {
"name": "Sagie Gur-Ari",
Expand Down Expand Up @@ -43,7 +43,7 @@
"grunt": "grunt"
},
"dependencies": {
"markdownlint": "^0.8.1"
"markdownlint": "^0.9.0"
},
"devDependencies": {
"chai": "latest",
Expand Down

4 comments on commit 2672f2b

@plroebuck
Copy link

@plroebuck plroebuck commented on 2672f2b Jun 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a BREAKING change! You removed support for Node4 with this update...
Your package version should have incremented the major version, not the patch version.

@sagiegurari
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, sorry about that

@plroebuck
Copy link

@plroebuck plroebuck commented on 2672f2b Jun 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet I see no changes. Either revert the "markdownlint" dependency upgrade, or pull your existing npm releases 1.1.5 & 1.1.6 and put out a replacement 2.0.0 (so you don't break anyone else's production package).

@sagiegurari
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 4 is really old and today you don't go to production without some lock file (yarn or npm) so I'm not so sure the change affected too many people.
if more people complain, I'll rethink this, but it was 3 weeks ago so i doubt it.
but i do agree with you and will be more careful for future upgrades.

Please sign in to comment.