Add queryGet.MAP #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It returns an object with pointers as keys and their respective value from the input data
|
Hi @benurb. I agree. Thanks for your efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sagold,
I thought about #1 a bit and came to the conclusion that neither dict() nor explode() work as a function name for me. json-pointer.dict() returns a dictionary of the input object independent of any pointers. And explode() implies the same for me. But the functionality this PR adds is merely a get() that returns an object instead of an array. So I implemented it this way. It was super simple and if you disagree about the change in the get() interface, it can be moved to a separate function easily. But then I would suggest a function name like map() or assoc().
Greetings,
Ben