Removed the "Unsigned" tag

saguiitay · Sep 16, 2023 · ca0bfb8 · ca0bfb8
1 parent a8bfdd1
commit ca0bfb8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 14 deletions.
diff --git a/.github/workflows/manual.yml b/.github/workflows/manual.yml
@@ -23,14 +23,14 @@ jobs:
         dotnet-version: 6.0.x
     - name: Restore dependencies
       run: dotnet restore
-    - name: Build Unsigned
-      run: dotnet build -c Release-Unsigned --no-restore
+    - name: Build
+      run: dotnet build -c Release --no-restore
     - name: Build Signed
       run: dotnet build -c Release-Signed --no-restore
-    - name: Push Unsigned to NuGet
+    - name: Push to NuGet
       run: |
-        dotnet pack -c Release-Unsigned -o $PWD/Release-Unsigned/nuget
-        for file in Release-Unsigned/nuget/*.nupkg; do dotnet nuget push -s https://api.nuget.org/v3/index.json -k ${{secrets.NUGET_API_KEY}} $file; done
+        dotnet pack -c Release -o $PWD/Release/nuget
+        for file in Release/nuget/*.nupkg; do dotnet nuget push -s https://api.nuget.org/v3/index.json -k ${{secrets.NUGET_API_KEY}} $file; done
     - name: Push Signed to NuGet
       run: |
         dotnet pack -c Release-Signed -o $PWD/Release-Signed/nuget

diff --git a/CardinalityEstimation.sln b/CardinalityEstimation.sln
@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio 15
-VisualStudioVersion = 15.0.27703.2047
+# Visual Studio Version 17
+VisualStudioVersion = 17.8.34112.27
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "CardinalityEstimation", "CardinalityEstimation\CardinalityEstimation.csproj", "{214AB5A6-DD68-432C-893A-0F6CC70D2005}"
 EndProject
@@ -12,7 +12,6 @@ Global
 		Debug|Any CPU = Debug|Any CPU
 		Release|Any CPU = Release|Any CPU
 		Release-Signed|Any CPU = Release-Signed|Any CPU
-		Release-Unsigned|Any CPU = Release-Unsigned|Any CPU
 	EndGlobalSection
 	GlobalSection(ProjectConfigurationPlatforms) = postSolution
 		{214AB5A6-DD68-432C-893A-0F6CC70D2005}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
@@ -21,8 +20,6 @@ Global
 		{214AB5A6-DD68-432C-893A-0F6CC70D2005}.Release|Any CPU.Build.0 = Release|Any CPU
 		{214AB5A6-DD68-432C-893A-0F6CC70D2005}.Release-Signed|Any CPU.ActiveCfg = Release-Signed|Any CPU
 		{214AB5A6-DD68-432C-893A-0F6CC70D2005}.Release-Signed|Any CPU.Build.0 = Release-Signed|Any CPU
-		{214AB5A6-DD68-432C-893A-0F6CC70D2005}.Release-Unsigned|Any CPU.ActiveCfg = Release-Unsigned|Any CPU
-		{214AB5A6-DD68-432C-893A-0F6CC70D2005}.Release-Unsigned|Any CPU.Build.0 = Release-Unsigned|Any CPU
 		{8029A737-1861-4FBB-A85E-BF4B50DF7135}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
 		{8029A737-1861-4FBB-A85E-BF4B50DF7135}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{8029A737-1861-4FBB-A85E-BF4B50DF7135}.Release|Any CPU.ActiveCfg = Release|Any CPU

diff --git a/CardinalityEstimation/CardinalityEstimation.csproj b/CardinalityEstimation/CardinalityEstimation.csproj
@@ -1,10 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <PropertyGroup>
         <TargetFrameworks>net6.0;netstandard2.0;netcoreapp3.1</TargetFrameworks>
-        <Configurations>Debug;Release;Release-Signed;Release-Unsigned</Configurations>
+        <Configurations>Debug;Release;Release-Signed</Configurations>
         <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
         <PackageId Condition=" '$(Configuration)' == 'Release-Signed' ">CardinalityEstimation.Signed</PackageId>
-        <PackageId Condition=" '$(Configuration)' == 'Release-Unsigned' OR '$(Configuration)' == 'Debug' ">CardinalityEstimation</PackageId>
+        <PackageId Condition=" '$(Configuration)' == 'Release' OR '$(Configuration)' == 'Debug' ">CardinalityEstimation</PackageId>
         <Version>1.11.1</Version>
         <Description>A C# library to estimate the number of unique elements in a set, in a quick and memory-efficient manner, based on the work of Flajolet et al. and Huele et al. Signed version.</Description>
         <Authors>Oron Navon;Sagui Itay</Authors>
@@ -21,7 +21,7 @@
         <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     </PropertyGroup>
 
-    <PropertyGroup Condition=" '$(Configuration)' == 'Release-Signed' OR '$(Configuration)' == 'Release-Unsigned'">
+    <PropertyGroup Condition=" '$(Configuration)' == 'Release-Signed' OR '$(Configuration)' == 'Release'">
         <DebugType>pdbonly</DebugType>
         <Optimize>True</Optimize>
     </PropertyGroup>
@@ -35,7 +35,7 @@
         <PackageReference Include="murmurhash-signed" Version="1.0.3" />
     </ItemGroup>
 
-    <ItemGroup Condition=" '$(Configuration)' == 'Release-Unsigned' OR '$(Configuration)' == 'Debug' ">
+    <ItemGroup Condition=" '$(Configuration)' == 'Release' OR '$(Configuration)' == 'Debug' ">
         <PackageReference Include="murmurhash" Version="1.0.3" />
     </ItemGroup>