This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
Add missing ESLint dependencies and drop PhantomJS integration testing #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npejo
approved these changes
Oct 31, 2017
|
Awesome! Thanks @xaviervia The build in Travis is failing because of an issue with Chrome Bin and PhantomJS 😭 We should try to find a fix for that in a separated PR first. I can help you out. |
|
This will fix #405 |
|
We need to merge #408 and update this branch. |
pirelenito
changed the title
We are about to phase-out support for it, and it is currently broken in Travis.
|
I've update this branch so that we get it green. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yarn and NPM are no longer flatting these dependencies, and we need to make them explicit of Sagui.
Also drops testing of PhantomJS since we are about to phase it out.