Skip to content

Commit

Permalink
Current flake8 no longer accepts comments on config lines (facebookre…
Browse files Browse the repository at this point in the history
…search#570)

* Current flake8 no longer accepts comments on config lines

`ValueError: Error code '#' supplied to 'extend-ignore' option does not match '^[A-Z]{1,3}[0-9]{0,3}$'`

* flake8==6.0.0

* Update .flake8

* Update setup.py

Co-authored-by: Stephen Roller <roller@fb.com>

Co-authored-by: Stephen Roller <roller@fb.com>
  • Loading branch information
cclauss and stephenroller committed Dec 30, 2022
1 parent db6842b commit ed85aad
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions .flake8
@@ -1,7 +1,10 @@
[flake8]
extend-ignore =
F541 # f-string is missing placeholders
E203 # whitespace with black
E741 # "l" is ambiguous
# E203: whitespace with black
E203
# E741: "l" is ambiguous
E741
# F541: f-string is missing placeholders
F541
# github size
max-line-length=127
2 changes: 1 addition & 1 deletion setup.py
Expand Up @@ -181,7 +181,7 @@ def do_setup(package_data):
),
extras_require={
"dev": [
"flake8==3.9.2",
"flake8",
"black==22.3.0",
# test deps
"iopath",
Expand Down

0 comments on commit ed85aad

Please sign in to comment.