Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shredder: Deleted locations come back #284

Closed
wallace11 opened this issue May 10, 2018 · 6 comments
Closed

Shredder: Deleted locations come back #284

wallace11 opened this issue May 10, 2018 · 6 comments

Comments

@wallace11
Copy link

wallace11 commented May 10, 2018

I'm using the latest V2.7, however this problem existed also in prior versions.

Steps to reproduce:

  1. Long-click on a location on the main page.
  2. Choose "Remove from list".
  3. Close Shredder.
  4. Opening Shredder again reveals the deleted folder.

Conformed on Ubuntu as well as on Arch.

@sahib
Copy link
Owner

sahib commented May 11, 2018

Hello @wallace11,

this is not really a bug, more a feature request. We simply do not persist the list anywhere. On startup it reads all user mounts and most recent directories into this list. The removal button is only there for convenience.

Is this something you think is useful for all people? If so, can you elaborate on your specific use case?

@sahib sahib added the feature label May 11, 2018
@wallace11
Copy link
Author

Oh, so I completely misunderstood how it works, then.

Well, if I should make a stand for my case, I'd like to point out that this behavior is unintuitive.
I've got global mounts on /mnt which aren't recognized by default. Upon adding top directories I'd like to get rid of its children and basically the front page is something I'd like to be able to customize for my liking, having only the paths I really need. For instance: I don't use my photos folder often, but this is one I'd like to always have on the list.
Furthermore, I can't help but wonder, doesn't the current behavior defeat the purpose of having a remove button?

In my opinion, the most intuitive way to do this is by populating the list on first run, and then keeping a custom list as the user adds/removes entries. It may also be appealing to some users to have an option in settings to "auto add most recent directories", which can be turned on or off.

Hope my explanation was clear enough and you'd consider accepting my suggestions.

@sahib
Copy link
Owner

sahib commented May 15, 2018

Hello @wallace11,

Well, if I should make a stand for my case, I'd like to point out that this behavior is unintuitive.
I've got global mounts on /mnt which aren't recognized by default. Upon adding top directories I'd like to get rid of its children and basically the front page is something I'd like to be able to customize for my liking, having only the paths I really need. For instance: I don't use my photos folder often, but this is one I'd like to always have on the list.

Sounds valid to me. Not all mounts are recognized by default - there is some internal logic of Gnome/GTK that I don't remember and need to lookup.

Furthermore, I can't help but wonder, doesn't the current behavior defeat the purpose of having a remove button?

Yes, in the current form it's somewhat pointless. Originally there was also a *De-/Select all" option where removal made sense when you wanted all but a few folders. I might implement something similar to what your proposed once I find the time.

@stonelike
Copy link

stonelike commented Sep 12, 2018

I second wallace11's confusion; I also found this behavior surprising and counter-intuitive, based on how the interface is designed.

The implicit suggestion at first glance is that removed items would stay removed between runs, as is very common in most GUI software; and nothing in the interface suggests otherwise. I thought the intended behavior was a bug before I read this thread.

wallace11's proposed behavior change is preferable for me also. (At the very least, tweaking the interface labels would reduce confusion as it is now.)

Thanks for your work.

@sahib
Copy link
Owner

sahib commented Sep 28, 2018

As of 49b80b8 the location entries get cached now. Only on the first run (or if they are not accessible) they are read from the most recently used folders / mounts. Give it a try.

@sahib sahib added this to the 2.8.0 Maidenly Moose milestone Oct 4, 2018
@sahib
Copy link
Owner

sahib commented Oct 29, 2018

Closing, since the original issue was resolved. Feel free to comment though.

@sahib sahib closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants