TEST: Add a test of various uses for UNMAP but no blocks to actually …

…unmap.

Makefile.am

@@ -64,7 +64,7 @@ bin_iscsi_test_SOURCES = test-tool/iscsi-test.c \
 	test-tool/0143_read12_rdprotect.c \
 	test-tool/0153_read16_rdprotect.c \
 	test-tool/0160_readcapacity16_simple.c \
-	test-tool/0170_unmap_simple.c
+	test-tool/0170_unmap_simple.c test-tool/0171_unmap_zero.c
 endif
 
 # LD_PRELOAD library.

test-tool/0171_unmap_zero.c

@@ -0,0 +1,185 @@
+/* 
+   Copyright (C) 2012 by Ronnie Sahlberg <ronniesahlberg@gmail.com>
+   
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+   
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+   
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include <stdio.h>
+#include "iscsi.h"
+#include "scsi-lowlevel.h"
+#include "iscsi-test.h"
+
+int T0171_unmap_zero(const char *initiator, const char *url)
+{ 
+	struct iscsi_context *iscsi;
+	struct scsi_task *task;
+	struct scsi_readcapacity16 *rc16;
+	int ret, i, lun;
+	uint32_t block_size, num_blocks;
+
+	iscsi = iscsi_context_login(initiator, url, &lun);
+	if (iscsi == NULL) {
+		printf("Failed to login to target\n");
+		return -1;
+	}
+
+	/* find the size of the LUN */
+	task = iscsi_readcapacity16_sync(iscsi, lun);
+	if (task == NULL) {
+		printf("Failed to send readcapacity16 command: %s\n", iscsi_get_error(iscsi));
+		ret = -1;
+		goto finished;
+	}
+	if (task->status != SCSI_STATUS_GOOD) {
+		printf("Readcapacity command: failed with sense. %s\n", iscsi_get_error(iscsi));
+		ret = -1;
+		scsi_free_scsi_task(task);
+		goto finished;
+	}
+	rc16 = scsi_datain_unmarshall(task);
+	if (rc16 == NULL) {
+		printf("failed to unmarshall readcapacity16 data. %s\n", iscsi_get_error(iscsi));
+		ret = -1;
+		scsi_free_scsi_task(task);
+		goto finished;
+	}
+
+	if (rc16->lbpme == 0){
+		printf("Logical unit is fully provisioned. Skipping test\n");
+		ret = -1;
+		scsi_free_scsi_task(task);
+		goto finished;
+	}
+
+	block_size = rc16->block_length;
+	num_blocks = rc16->returned_lba;
+
+	scsi_free_scsi_task(task);
+
+	if (!data_loss) {
+		printf("data_loss flag is not set. Skipping test\n");
+		ret = -1;
+		goto finished;
+	}
+
+	ret = 0;
+
+	/* unmap no blocks at the first 0 - 256 blocks at the start of the LUN */
+	printf("Unmapping of no block at lbas 0-255 blocks ... ");
+	for (i=0; i<=255; i++) {
+		struct unmap_list list[1];
+
+		list[0].lba = i;
+		list[0].num = 0;
+		task = iscsi_unmap_sync(iscsi, lun, 0, 0, &list[0], 1);
+		if (task == NULL) {
+		        printf("[FAILED]\n");
+			printf("Failed to send UNMAP command: %s\n", iscsi_get_error(iscsi));
+			ret = -1;
+			goto finished;
+		}
+		if (task->status != SCSI_STATUS_GOOD) {
+		        printf("[FAILED]\n");
+			printf("UNMAP command: failed with sense. %s\n", iscsi_get_error(iscsi));
+			ret = -1;
+			scsi_free_scsi_task(task);
+			goto finished;
+		}
+		scsi_free_scsi_task(task);
+	}
+	printf("[OK]\n");
+
+
+	/* unmap no blocks at the last 0 - 255 blocks at the end of the LUN */
+	printf("Unmapping last 1-256 blocks ... ");
+	for (i=0; i<=255; i++) {
+		struct unmap_list list[1];
+
+		list[0].lba = num_blocks + 1 - i;
+		list[0].num = 0;
+		task = iscsi_unmap_sync(iscsi, lun, 0, 0, &list[0], 1);
+		if (task == NULL) {
+		        printf("[FAILED]\n");
+			printf("Failed to send UNMAP command: %s\n", iscsi_get_error(iscsi));
+			ret = -1;
+			goto finished;
+		}
+		if (task->status != SCSI_STATUS_GOOD) {
+		        printf("[FAILED]\n");
+			printf("UNMAP command: failed with sense. %s\n", iscsi_get_error(iscsi));
+			ret = -1;
+			scsi_free_scsi_task(task);
+			goto finished;
+		}
+		scsi_free_scsi_task(task);
+	}
+	printf("[OK]\n");
+
+	/* unmap no blocks 1-256 blocks beyond the end of the LUN */
+	printf("Unmapping no blocks but 1-256 blocks beyong end of LUN... ");
+	for (i=1; i<=256; i++) {
+		struct unmap_list list[1];
+
+		list[0].lba = num_blocks + 1 + i;
+		list[0].num = 0;
+		task = iscsi_unmap_sync(iscsi, lun, 0, 0, &list[0], 1);
+		if (task == NULL) {
+		        printf("[FAILED]\n");
+			printf("Failed to send UNMAP command: %s\n", iscsi_get_error(iscsi));
+			ret = -1;
+			goto finished;
+		}
+		if (task->status == SCSI_STATUS_GOOD) {
+		        printf("[FAILED]\n");
+			printf("STATUS==GOOD. UNMAP command should fail with ILLEGAL_REQUEST/LBA_OUT_OF_RANGE.\n");
+			ret = -1;
+			scsi_free_scsi_task(task);
+			goto finished;
+		}
+		if (task->status        != SCSI_STATUS_CHECK_CONDITION
+		    || task->sense.key  != SCSI_SENSE_ILLEGAL_REQUEST
+		    || task->sense.ascq != SCSI_SENSE_ASCQ_LBA_OUT_OF_RANGE) {
+		        printf("[FAILED]\n");
+			printf("UNMAP fail but ascq was wrong. Should have failed with ILLEGAL_REQUEST/LBA_OUT_OF_RANGE.\n");
+			ret = -1;
+			scsi_free_scsi_task(task);
+			goto finished;
+		}
+		scsi_free_scsi_task(task);
+	}
+	printf("[OK]\n");
+
+	/* unmap with no block descriptors at all */
+	printf("Unmap without any block descriptors ... ");
+	task = iscsi_unmap_sync(iscsi, lun, 0, 0, NULL, 0);
+	if (task == NULL) {
+	        printf("[FAILED]\n");
+		printf("Failed to send UNMAP command: %s\n", iscsi_get_error(iscsi));			ret = -1;
+		goto finished;
+	}
+	if (task->status != SCSI_STATUS_GOOD) {
+	        printf("[FAILED]\n");
+		printf("UNMAP command: failed with sense. %s\n", iscsi_get_error(iscsi));
+		ret = -1;
+		scsi_free_scsi_task(task);
+		goto finished;
+	}
+	scsi_free_scsi_task(task);
+	printf("[OK]\n");
+
+finished:
+	iscsi_logout_sync(iscsi);
+	iscsi_destroy_context(iscsi);
+	return ret;
+}

test-tool/iscsi-test.c

@@ -70,6 +70,7 @@ struct scsi_test tests[] = {
 
 /* unmap*/
 { "T0170_unmap_simple",			T0170_unmap_simple },
+{ "T0171_unmap_zero",			T0171_unmap_zero },
 
 { NULL, NULL }
 };

test-tool/iscsi-test.h

@@ -46,3 +46,4 @@ int T0153_read16_rdprotect(const char *initiator, const char *url);
 int T0160_readcapacity16_simple(const char *initiator, const char *url);
 
 int T0170_unmap_simple(const char *initiator, const char *url);
+int T0171_unmap_zero(const char *initiator, const char *url);