test-tool: rework iscsi_queue_pdu() overloading #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test performs PDU manipulation so should only be run against iSCSI devices. Signed-off-by: David Disseldorp <ddiss@suse.de>
In preparation for removing the test-tool iscsi_queue_pdu() dlsym overload hack, convert the Compare&Write InvalidDataOutSize test to use the regular transport driver callback for this purpose. Signed-off-by: David Disseldorp <ddiss@suse.de>
In preparation for removing the test-tool iscsi_queue_pdu() dlsym overload hack, convert this test to use the regular transport driver callback for this purpose. Signed-off-by: David Disseldorp <ddiss@suse.de>
In preparation for removing the test-tool iscsi_queue_pdu() dlsym overload hack, convert this test to use the regular transport driver callback for this purpose. Signed-off-by: David Disseldorp <ddiss@suse.de>
In preparation for removing the test-tool iscsi_queue_pdu() dlsym overload hack, convert this test to use the regular transport driver callback for this purpose. This commit also removes a number of unnecessary "WRITE10 is not implemented" checks, which should all be caught by the first check. Signed-off-by: David Disseldorp <ddiss@suse.de>
This test performs PDU manipulation so should only be run against iSCSI devices. Signed-off-by: David Disseldorp <ddiss@suse.de>
In preparation for removing the test-tool iscsi_queue_pdu() dlsym overload hack, convert this test to use the regular transport driver callback for this purpose. Signed-off-by: David Disseldorp <ddiss@suse.de>
This test performs PDU manipulation so should only be run against iSCSI devices. Signed-off-by: David Disseldorp <ddiss@suse.de>
In preparation for removing the test-tool iscsi_queue_pdu() dlsym overload hack, convert this test to use the regular transport driver callback for this purpose. Signed-off-by: David Disseldorp <ddiss@suse.de>
This test performs PDU manipulation so should only be run against iSCSI devices. Signed-off-by: David Disseldorp <ddiss@suse.de>
In preparation for removing the test-tool iscsi_queue_pdu() dlsym overload hack, convert this test to use the regular transport driver callback for this purpose. Signed-off-by: David Disseldorp <ddiss@suse.de>
All users have now been changed to overload via the iscsi_ctx transport callback, so the dlsym based overloading can now be dropped. Signed-off-by: David Disseldorp <ddiss@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-tool/iscsi-support.c includes it's own iscsi_queue_pdu() function, which can be used by tests for intercepting PDU dispatch and falling through to the libiscsi path via dlsym() lookup.
With #297 we want to allow the test tool to directly use low-level libiscsi functions, which is complicated by the duplicate iscsi_queue_pdu() symbol.
The iSCSI context already includes a transport-specific queue_pdu() callback, so use that for overloading instead.