Support Win32 compilation with Mingw #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not change a thing for MSVC, but This is needed for Cross-Compiling with Mingw/Mingw-w64
It depends on stat features that are not available
So that the definition and declaration match. There might be another way, with stat64i32 but I'm not confident it will work with MSVC
This fixes build with options such as --as-needed that require correct positional argument passing. They also ensure that the right dependency library is used.
…e built where expected.
|
Ping :) |
sahlberg
added a commit
that referenced
this pull request
Jan 16, 2016
Support Win32 compilation with Mingw
|
Awesome! Merged. |
|
Rocks :) |
|
Could you add a short sentence about MINGW to the README file too ? On Sat, Jan 16, 2016 at 8:54 AM, Jean-Baptiste Kempf <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of patches that should allow to cross-compile this library through Mingw on Linux
This is using autotools to compile for Win32, and not the win32build.bat
Some stuff are a bit kludgy to be honest, but the existing code was already a bit weird (nfs_stat declaration is fishy).
Some more work is required, I believe to clean everything for Win32, but this should be a good first step.