Cygwin should not use winsock2 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configure.ac script was erroneously including -lws2_32, i.e. the winsock2 library. Cygwin is a full POSIX environment and does not need the winsock2 functionality as it supplies its own POSIX compatible sockets. Including -lws2_32 caused getnameinfo to fail with error 10093 (WSANOTINITIALISED). This usually means that the Winsock WSAStartup function has not been called. Calling WSAStartup is not necessary for Cygwin programs and in fact should be avoided.
|
Merged. Thanks. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the commit message: