Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing cmake build on windows #297

Merged
merged 4 commits into from Oct 9, 2019
Merged

Conversation

crusader-mike
Copy link
Contributor

@crusader-mike crusader-mike commented Sep 13, 2019

I've got cmake build to work on Windows x64. Notes:

  • tidied up cmake files a bit
  • fixed one problem where SOCKET was truncated to int; there is another one (see what happens to handle returned by create_socket()), but it has to be fixed another time
  • there are other warnings that need to be addressed at some point, but they seem to be minor
  • dll version info is generated properly
  • with this change it is trivial to add libnfs to vcpkg. See libnfs.zip

@sahlberg sahlberg merged commit ac60fea into sahlberg:master Oct 9, 2019
@crusader-mike
Copy link
Contributor Author

@sahlberg Did I just managed to sneak in last minute fix before you merged it in or you were waiting for me to notice and fix a "missing exports" problem? :-)

@sahlberg
Copy link
Owner

sahlberg commented Oct 9, 2019 via email

@crusader-mike
Copy link
Contributor Author

crusader-mike commented Oct 9, 2019

No, I pushed last commit (9d5427b fix for missing exports) literally a minute before you merged in the change. It looked like I managed to squeeze that fix right before you pressed "merge" button. Quite possible you didn't see new change (if I checked it in after you looked got github page, but before you pressed merge button) -- in this case it would be a github bug.

I just found this thought humorous...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants