Rewrite build system using automake

[t-nelson]

Title says it all.

This should improve portability and cross builds by eliminating assumptions and custom tests.

I think I got most of the functionality of the current build system back in place. The log path configure withvar was left out since I didn't see where it was used anymore. Versioning was also change to the Right Way(tm) according to libtool. See http://www.gnu.org/software/libtool/manual/html_node/Versioning.html#Versioning

[Memphiz]

Just to give my 2 cents here. I think libnfs with such a buildsys is a big step for getting it into the distros ... :D

[sahlberg]

Can you re-do the patch for my current git tree.

I tried to back the changes I have made to Makefile.in that prevented the merge from working originally
but it looks like some stuff is still missing so I could get it to build with the autotools.

[sahlberg]

Never mind. There were some junk in my local git tree.
I have merged your patches now.

Thanks!

[t-nelson]

Great. Thanks for the merge. Feel free to contact me if you have any questions re autotools in the future. I'm no pro but I'm sure I can help you along.

[sahlberg]

Thanks.

Did you compile and run this successfully from Solaris? If so, could you create a patch for README that Solaris works ?
May I ask which project you use libnfs for, hence your interest to help make it better?

Also, If you want to, I would be very grateful if you volunteer to do the same kind of autotools conversion for libiscsi too :-)

thanks for your help to make libnfs better.

ronnie s

[t-nelson]

I'm another xbmc dev.

I tested with opensolaris. I'm not sure what the differences are between that and the real deal. I don't have Solaris available.

I'll try to take a look at libiscsi if I can get some free time in the next week.

[sahlberg]

I think the main difference between the two for an application is
probably just the endianness with opensolaris mainly running on
le-systems and the real deal running on be-systems.
This code does not have any endinanness dependencies so should work on all.

It even works on weirdo PPC/AIX afaik with its weird changes to
'struct sockaddr'

:-)

On Sat, Jul 2, 2011 at 3:28 PM, t-nelson
reply@reply.github.com
wrote:

I'm another xbmc dev.

I tested with opensolaris. I'm not sure what the differences are between that and the real deal. I don't have Solaris available.

I'll try to take a look at libiscsi if I can get some free time in the next week.

Reply to this email directly or view it on GitHub:
#6 (comment)

[sahlberg]

Ouch, that reminds me.

Your patch quite likely actually broke AIX and all other legacy unixens that have a
specific sock addr length field

#ifdef HAVE_SOCK_SIN_LEN
sin->sin_len = socksize;
#endif

This kind of code. On legacy unixen we need to know if sockaddr structure needs a sin_len assigment or things will break.

Could you add detection of whether HAVE_SOCK_SIN_LEN checks back to the configure checks and to config.h, else legacy unixens will break.

[sahlberg]

Oh man

This just reminded me on why and how much I hate libtools with such a passion.
It breaks both gdb and valgrind so they become almost useless.

Do you know the command line to use to get meaningful valgrind output
for for example ./examples/nfsclient-bcast which should provide a
warning about conditional jump depending on an unitialized variable ?

regards
ronnie sahlberg

On Sat, Jul 2, 2011 at 11:26 AM, t-nelson
reply@reply.github.com
wrote:

Great. Thanks for the merge. Feel free to contact me if you have any questions re autotools in the future. I'm no pro but I'm sure I can help you along.

Reply to this email directly or view it on GitHub:
#6 (comment)

[t-nelson]

nelson11@zoidberg:~/code/libnfs/examples$ libtool --mode=execute valgrind -v --leak-check=full --show-reachable=yes ./nfsclient-bcast

Seems to do the trick.