Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shared folder with ; or @ issue #202

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Conversation

NicolasLQ
Copy link

smb2_parse_url function needs an URL with the format :
smb://[<domain;][@]//

When optional args are not provided, the parser will still search them
and maybe find them in the /. If the delimiters ; or @
are found in it, this will pose a problem to analyze the parsing.

Fixes #84

smb2_parse_url function needs an URL with the format :
smb://[<domain;][<username>@]<server>/<share>/<path>

When optional args are not provided, the parser will still search them
and maybe find them in the <share>/<path>. If the delimiters ; or @
are found in it, this will pose a problem to analyze the parsing.

Fixes sahlberg#84
@sahlberg sahlberg merged commit 6db0138 into sahlberg:master Jun 20, 2021
@sahlberg
Copy link
Owner

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smb2_parse_url parse has bug when no domain.
2 participants