Skip to content
This repository has been archived by the owner on Apr 4, 2021. It is now read-only.

Function needs season_type added #8

Closed
rvino opened this issue Sep 13, 2020 · 2 comments
Closed

Function needs season_type added #8

rvino opened this issue Sep 13, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@rvino
Copy link

rvino commented Sep 13, 2020

The cfb_stats_game_advanced function appears to actually only have two season type options: 'postseason' and 'both' and doesn't have a 'regular' option.

The following
cfb_stats_game_advanced( 2019, week = 1, team = NULL, opponent = NULL, excl_garbage_time = FALSE, season_type = "regular" )
produced this error
Error: Enter valid season_type (String): regular, postseason, or both
Traceback:
1. cfb_stats_game_advanced(2019, week = 1, team = NULL, opponent = NULL,
. excl_garbage_time = FALSE, season_type = "regular")
2. assertthat::assert_that(season_type %in% c("postseason", "both"),
. msg = "Enter valid season_type (String): regular, postseason, or both")

@saiemgilani
Copy link
Owner

saiemgilani commented Sep 13, 2020

Taken care of. Silly mistake, thanks for catching it. You can update. Closed by https://github.com/saiemgilani/cfbscrapR/commit/68cf659eeab96720e3583f69e9ba30747e52aa8b

@saiemgilani
Copy link
Owner

@saiemgilani saiemgilani added the good first issue Good for newcomers label Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants