-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fate chart and scene alteration macros fail with GURPS #3
Comments
Hello @jonatanhedborg thank you for taking the time to come and report this issue. Could you share a bit of context, what were you doing at the time? - Is there any modules that could be affecting Rolling Dice or Sending Dice to the Chat that could affect this module? Also which System are you on? |
@saif-ellafi No problems, thanks for implementing this! I was simply trying to test it out, dragged the macros to the bar and tried them.
I will try with a different system and see if it works differently. |
It appears to be working in the Savage Worlds system, so it's probably some incompatibility with GURPS (I just tried creating a new, clean world in case there was something messed up in some migration, but it did not help). |
Thank you for investigating. Will flag this for when I get some time. Could be worth while to share with GURPS people? |
I am one of the coauthors of the GURPS ruleset. I have installed this module and imported the macros, but I don't see what is wrong. I can roll on any of the included roll tables without error. How do I replicate the bug? |
@mjeffw It happens (or rather, doesn't happen) when you try to use the macros for fate chart and scene alteration. |
Okay -- I see the problem now. The cause is that the GURPS system does not use the standard roll chat message. I could try to fix the immediate problem -- that the roll message data does not have a 'total' value -- but that may just reveal yet another problem. Instead of chasing them one by one, could you describe what this module is attempting to do? |
Actually, I don't know what the problem is here -- it doesn't look like we're creating a custom chat message. EDIT: I found the cause. The GURPS System overrides the standard Dice type with its own (GurpsDie) to allow for certain special abilities, and this module tries to create a roll chat message with the standard Dice type. I can try to allow both Dice types to be valid, but it might be dicey (sorry, couldn't resist). |
Thank you @mjeffw for looking into this. I have of course no idea about how GURPS work or your implementation, but indeed it might help for module compatibility to have standard APIs wherever possible :) best regards! |
@mjeffw Hi there! - Not sure if there is any progress on the compatibility between this module and your system? :) |
@jonatanhedborg Is this still an issue with the latest version of Mythic GME Tools? |
Attached console log and screenshot of said console output
I'm running Foundry version 0.8.9.
127.0.0.1-1636150700422.log
The text was updated successfully, but these errors were encountered: