Skip to content

Commit

Permalink
Change name of express_port to dev_app_port so people know not to use…
Browse files Browse the repository at this point in the history
… it in production
  • Loading branch information
saikat committed Jul 12, 2016
1 parent 93527ce commit 4fa3391
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .env
@@ -1,5 +1,5 @@
NODE_ENV=development
EXPRESS_PORT=8080
DEV_APP_PORT=8080
ROLLBAR_ACCESS_TOKEN=set_this_in_production
OUTPUT_DIR=./build
PUBLIC_DIR=./build/client
Expand Down
3 changes: 2 additions & 1 deletion src/server/index.js
Expand Up @@ -13,7 +13,8 @@ process.on('uncaughtException', (ex) => {
})

const app = express()
const port = process.env.NODE_ENV === 'production' ? process.env.PORT : process.env.EXPRESS_PORT
// Heroku requires you to use process.env.PORT
const port = process.env.DEV_APP_PORT || process.env.PORT
// Don't rate limit heroku
app.enable('trust proxy')

Expand Down
2 changes: 1 addition & 1 deletion webpack/server.js
Expand Up @@ -4,7 +4,7 @@ import config from './config'
import log from '../src/server/log'

const webpackPort = 3000
const appPort = process.env.EXPRESS_PORT
const appPort = process.env.DEV_APP_PORT

Object.keys(config.entry)
.forEach((key) => {
Expand Down

0 comments on commit 4fa3391

Please sign in to comment.