Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acme example #157

Merged
merged 38 commits into from
Jun 23, 2022
Merged

Add acme example #157

merged 38 commits into from
Jun 23, 2022

Conversation

lkevinzc
Copy link
Contributor

Description

We add acme example code used in producing the Appendix results.

Motivation and Context

This is to show the generality of EnvPool and demonstrate a sample integration with Acme.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • New environment (non-breaking change which adds 3rd-party environment)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the code using make lint (required)
  • I have ensured make bazel-test pass. (required)

@Trinkle23897 Trinkle23897 mentioned this pull request Jun 22, 2022
13 tasks
@Trinkle23897 Trinkle23897 linked an issue Jun 22, 2022 that may be closed by this pull request
5 tasks
@Trinkle23897
Copy link
Collaborator

Trinkle23897 commented Jun 22, 2022

  • readme
  • format
  • citation update and rl_games reference
  • openrlbenchmark link in examples/acme/readme.md

I'll do these today.

Trinkle23897
Trinkle23897 previously approved these changes Jun 23, 2022
@Trinkle23897 Trinkle23897 merged commit c3f17dc into sail-sg:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] ACME Integration
2 participants