Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filecase.pro] Beautify and expand a comment #70

Merged
merged 3 commits into from
Feb 24, 2024
Merged

[filecase.pro] Beautify and expand a comment #70

merged 3 commits into from
Feb 24, 2024

Conversation

Olf0
Copy link
Collaborator

@Olf0 Olf0 commented Feb 24, 2024 •
edited

… by cherry-picking and extending PR #69.

@Olf0
[filecase.pro] Fix translations for OBS-build
1056342 
… by cherry-picking and extending PR #69.
@Olf0 Olf0 self-assigned this Feb 24, 2024
Olf0
Olf0 commented Feb 24, 2024
View reviewed changes
Copy link
Collaborator Author

@Olf0 Olf0 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.paths are usually not concluded with a /, according to the Qt documentation, but a trailing / apparently does not matter.

@Olf0
Copy link
Collaborator Author

Olf0 commented Feb 24, 2024

This was nonsense, misguided by #69, because the error message has always been (but nobody looked at it):
[ 228s] lupdate: could not exec '/usr/lib/qt5/bin/lupdate': No such file or directory
[ 228s] lrelease: could not exec '/usr/lib/qt5/bin/lrelease': No such file or directory

@Olf0 Olf0 closed this Feb 24, 2024
@Olf0 Olf0 reopened this Feb 24, 2024
Olf0
Olf0 commented Feb 24, 2024
View reviewed changes
Copy link
Collaborator Author

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Olf0 Olf0 changed the title [filecase.pro] Fix translations for OBS-build [filecase.pro] Beautify and expand a comment Feb 24, 2024
@Olf0 Olf0 merged commit a0ef02c into devel Feb 24, 2024
1 check passed
@Olf0 Olf0 deleted the fix-translations-at-obs branch February 24, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Olf0 Olf0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Olf0