Skip to content

Commit

Permalink
nir: return progress from nir_lower_packing
Browse files Browse the repository at this point in the history
Compiling with clang warns about an unused variable in
nir_lower_packing.

Tracking progress was added to nir_lower_packing in
adb157d but the function
will ignore the progress from impl calls and always return
false.

This patch changes it to return the progress. It fixes the
warning and should enable validation calls in NIR_PASS when
progress is made.

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Fixes: adb157d "nir: Return progress from nir_lower_64bit_pack()"
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11615>
  • Loading branch information
phomes authored and Marge Bot committed Jun 29, 2021
1 parent a92dcc4 commit ed530ac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/compiler/nir/nir_lower_packing.c
Expand Up @@ -162,5 +162,5 @@ nir_lower_pack(nir_shader *shader)
progress |= lower_pack_impl(function->impl);
}

return false;
return progress;
}

0 comments on commit ed530ac

Please sign in to comment.