Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[buteo-sync-plugin-webcal] Use lcWebCal logging category instead of Buteo LOG_* macros. JB#53712 #2

Merged
merged 1 commit into from Aug 29, 2021
Merged

[buteo-sync-plugin-webcal] Use lcWebCal logging category instead of Buteo LOG_* macros. JB#53712 #2

merged 1 commit into from Aug 29, 2021

Conversation

blammit
Copy link
Contributor

@blammit blammit commented Aug 11, 2021

No description provided.

@blammit blammit requested a review from chriadam August 11, 2021 06:13
dcaliste
dcaliste suggested changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@dcaliste dcaliste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like in the CalDAV plugin, I put also a line like qputenv("MSYNCD_LOGGING_LEVEL", "8"); in the tests. It needs to be updated.

Thank you for the changes here to use Qt logging categories.

pvuorela
pvuorela reviewed Aug 13, 2021
View reviewed changes
src/webcalclient.h Outdated Show resolved Hide resolved
pvuorela
pvuorela approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple and good, and suppose could be merged already

@pvuorela
Copy link
Contributor

Oh, didn't notice Damien's comment on the code tab. Removal enough maybe?

@dcaliste
Copy link
Contributor

Removal enough maybe?

Yes, indeed, one can completely remove the line making the qsetenv. After all, I put it there the first time in CalDAV to actually don't have to remember it... While, now that we're using standard Qt logging, one can turn on or off the debug messages with a standard way.

@blammit blammit merged commit 038f782 into master Aug 29, 2021
@rainemak rainemak deleted the jb53712-logging branch January 26, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcaliste dcaliste dcaliste requested changes

@pvuorela pvuorela pvuorela approved these changes

@chriadam chriadam chriadam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@blammit @pvuorela @dcaliste @chriadam