[commhistoryd] Fix group matching when there are multiple recipients. Fixes JB#55101 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commented elsewhere that this should have a new issue to tracking if there's a bug. But I'm not either following from the commit what exactly is this fixing. cc @blammit |
… Fixes JB#55101 When you find an individual chat, use it. Incoming messages are not added to group chats.
xlise
changed the title
|
Looking again, still not entirely sure from the change and the commit message on what this fixes. Only difference if there was something found on the last iteration, I think. The search if broken only on that case? |
|
Yes seems the difference would be if it was found on the last iteration. In general the fix seems to make sense since the current implementation may set m_Group in line 1517 then overwrite it in line 1525. |
blammit
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you find an individual chat, use it. Incoming messages are not added to group chats.