Add UserStorage conf option, update documentation on storage paths #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[storage] Set user storage path at init. JB#61888 Change to set user storage path at storage initialization. Require both storage root and user dir at initialization. Use the user storage dir instead of build time default.
[main] Add support for UserStorage path configuration. JB#61888 Read "UserStorage" from the configuration file and use it for storage initialization as path for user specific data when multiuser is enabled. Use the default build time path for both storage root and user storage when omitted from configuration file.
[vpn-settings] Add support for UserStorage path configuration. JB#61888 Read "UserStorage" from the configuration file. Use the default build time path for both storage root and user storage when omitted from configuration file.
[vpn] Use user storage dir for storage init. JB#61888
mlehtima
approved these changes
Apr 10, 2024
[doc] Update config file storage paths descriptions. JB#61888 Change the description to detail the default build time set values for both StorageRoot and UserStorage paths. Change the default UserStorage to be ".config" in Makefile.am. The paths are read from configuration files on both connman and connman-vpn.
mlehtima
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the UserStorage path as configuration option read from configuration files by both connmand and connman-vpnd instead of having it as a build time parameter.
StorageRootcan be set in the configuration files as well, so it is same to have this one there too. These paths need to be in sync on both, though.Fixed many unit tests that depended on this as the
UserStorageis used now at storage.c initialization.Updated the documentation on that part as well to define that the default paths can be modified through configuration files.