Create Storage Space document #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovirkku
reviewed
Nov 28, 2022
jovirkku
reviewed
Nov 28, 2022
jovirkku
reviewed
Nov 28, 2022
jovirkku
reviewed
Nov 28, 2022
jovirkku
reviewed
Nov 28, 2022
|
I left some comments. Mostly about slight improvements. The document is ok. |
Thanks, good comments, I'll check those through and update. |
jpwalden
force-pushed
the
Storage_Space_JB59453
branch
from
0029912
to
35022a8
Compare
Signed-off-by: jari-pekka walden <jari-pekka.walden@jolla.com>
jpwalden
force-pushed
the
Storage_Space_JB59453
branch
from
35022a8
to
ab6a7ff
Compare
|
I assume needed fixes have been now done, could this be approved now? |
vigejolla
approved these changes
Nov 29, 2022
Yup, somehow I missed your changes yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jari-pekka walden jari-pekka.walden@jolla.com