Buffers are not always recycled automatically #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ifc1b59535c34c12a1db11808b0ae6c59337dee20
…eir resources when replaced.
mlehtima
reviewed
Aug 17, 2023
mlehtima
reviewed
Aug 17, 2023
Change-Id: I323b20177b4298cf5848266e84bf9d73d9084c6f
Change-Id: I4c576c5d1b44b014a69aa0ab131491cd52e5c678
Change-Id: I8492f91eca7c8709faae42a2f1be69108c932a3a
Change-Id: Ia25af46b92b6b53a6fa0d262bf89cd10e73add94
Change-Id: Ife94eb380e2d9488a1dfdec1a2526d926e284c3e
Change-Id: I7b5f6c1b2f142ef46a9cf73c3ccaa33e691b306f
Change-Id: I594c5cecfbf582e15cb20a7e79230897d4882f12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was observed on asus sake, media buffers on, a lineage-18.1 port which uses media buffers: the mGraphicBuffer was not recycled (did not come null). The previous one from the slot needed to be unref'd.
The pointer itself is not, since clients are not aware of this change.
So a pointer tracking was introduced that allows clients to have
DroidMediaBufferpointers even if they are devoid of resources until thereleaseBufferscall comes in which also clears the memory.