Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[xulrunner] Make fullscreen enabling work as used to with pref full-s…
…creen-api.content-only. Fixes JB#44129 We don't have chrome from doc shell point of view. This commit sha1 3116f3b offends fullscreen API to work without chrome and shall not make root docShell act as chrome. We previously had "full-screen-api.content-only" pref set to "true".
- Loading branch information
Showing
2 changed files
with
42 additions
and
0 deletions.
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
rpm/0012-xulrunner-Make-fullscreen-enabling-work-as-used-to-w.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
From d291c69ef662fd7b77946f764f63474a86d9115c Mon Sep 17 00:00:00 2001 | ||
From: Raine Makelainen <raine.makelainen@jolla.com> | ||
Date: Thu, 10 Jan 2019 15:21:24 +0200 | ||
Subject: [PATCH 12/12] [xulrunner] Make fullscreen enabling work as used to | ||
with pref full-screen-api.content-only. Fixes JB#44129 | ||
|
||
We don't have chrome from doc shell point of view. This commit | ||
sha1 3116f3bf53df offends fullscreen API to work without chrome | ||
and shall not make root docShell act as chrome. We previously had | ||
"full-screen-api.content-only" pref set to "true". | ||
|
||
Signed-off-by: Raine Makelainen <raine.makelainen@jolla.com> | ||
--- | ||
dom/base/nsGlobalWindow.cpp | 6 ++++++ | ||
1 file changed, 6 insertions(+) | ||
|
||
diff --git a/dom/base/nsGlobalWindow.cpp b/dom/base/nsGlobalWindow.cpp | ||
index 080b0302f021..c90f4271765f 100644 | ||
--- a/dom/base/nsGlobalWindow.cpp | ||
+++ b/dom/base/nsGlobalWindow.cpp | ||
@@ -6032,10 +6032,16 @@ nsGlobalWindow::SetFullscreenInternal(FullscreenReason aReason, | ||
if (rootItem != mDocShell) | ||
return window->SetFullscreenInternal(aReason, aFullScreen, aHMD); | ||
|
||
+ // We don't have chrome from doc shell point of view. This commit | ||
+ // sha1 3116f3bf53df offends fullscreen API to work without chrome | ||
+ // and shall not make root docShell act as chrome. We previously had | ||
+ // "full-screen-api.content-only" pref set to "true". | ||
+#if 0 | ||
// make sure we don't try to set full screen on a non-chrome window, | ||
// which might happen in embedding world | ||
if (mDocShell->ItemType() != nsIDocShellTreeItem::typeChrome) | ||
return NS_ERROR_FAILURE; | ||
+#endif | ||
|
||
// If we are already in full screen mode, just return. | ||
if (mFullScreen == aFullScreen) | ||
-- | ||
2.20.1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters