[sailfishos][gecko] Fix delivery of MozAfterPaint events. JB#55286 OMP#JOLLA-310 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainemak
reviewed
Sep 13, 2021
rpm/0001-Revert-Bug-1445570-Remove-EnsureEventualAfterPaint-t.patch
Outdated
Show resolved
Hide resolved
rainemak
reviewed
Sep 13, 2021
|
I have used "[sailfishos][embedlite]" to ref embedding/embedlite i.e. ones that are not patches. As this is revert and patch this could be "[sailfishos][gecko]". |
rainemak
approved these changes
Sep 14, 2021
adenexter
changed the title
okodron
approved these changes
Sep 15, 2021
…P#JOLLA-310 Revert a patch to remove an ensure eventual after paint event timer as no event is delivered in embedlite without it. The short explanation is that the root widget (an embedlite puppet widget) of the PresContext where the event is scheduled, is not the same root widget as in the ClientLayerManager (nsWindow) where the paint is completed, so the nsView installed as the widget listener on the puppet widget doesn't have the DidCompositeWindow called via ClientLayerManager::DidComposite. And even with a redirect established there's a subsequent failure because the DidComposite is a posted event and the transaction it refers to is gone when it executes.
|
Took a liberty to rebase this one. CC @adenexter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert a patch to remove an ensure eventual after paint event timer as
no event is delivered in embedlite without it.
The short explanation is that the root widget (an embedlite puppet
widget) of the PresContext where the event is scheduled, is not the same
root widget as in the ClientLayerManager (nsWindow) where the paint is
completed, so the nsView installed as the widget listener on the puppet
widget doesn't have the DidCompositeWindow called via
ClientLayerManager::DidComposite. And even with a redirect established
there's a subsequent failure because the DidComposite is a posted event
and the transaction it refers to is gone when it executes.