Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] Update to version 2.34.5. JB#59426 #5

Merged
merged 1 commit into from Nov 24, 2022
Merged

[git] Update to version 2.34.5. JB#59426 #5

merged 1 commit into from Nov 24, 2022

Conversation

martyone
Copy link
Member

No description provided.

@martyone
Copy link
Member Author

Chose version 2.34, which is used in Ubuntu 22.04 LTS.

See https://github.com/sailfishos-mirror/git/blob/v2.34.5/contrib/hooks/multimail/README.Git regarding multimail removal.

Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I hope no one was using multimail.

@Thaodan
Copy link

Thaodan commented Nov 22, 2022 via email

@martyone
Copy link
Member Author

Why not straight up go to the latest?

To limit the risk for issues with accessing a git repo with two tools of different versions - one on host, the other inside the build engine/chroot. We have seen such issues and it naturally happens more often on the side with older git (after the repo was touched by the newer git). So better if the git inside sdk is older than the one on host if they do not match.

@martyone martyone merged commit c8fa4e4 into master Nov 24, 2022
@martyone martyone deleted the jb59426 branch November 24, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants