[kf5-calendarcore] Update to latest upstream 5.90. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While waiting for the upstream discussion to proceed, guess we could also just do the upgrade out of the way. |
dcaliste
changed the title
|
Ok, let's do like that. I've removed the WIP mention. I noticed that I went one commit further than 5.90 in the upstream submodule. Is it an issue ? Do you prefer that I stick to the 5.90 tag ? |
|
I'm ok with either this or the official 5.90. Not too many times changes are reverted upstream. Seems good to me, though noticed I had tagged the extra-cmake-modules wrong earlier, without the trailing .0 and the version requirement here didn't work. Just pushed a new tag there and I'll get into this once it's in. |
pvuorela
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It relies on sailfishos/extra-cmake-modules#2
It is at the moment a simple update to latest upstream, not to lag too much behind.
It may be wise though to wait for https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/84 to settle (about the listing of cancelled events) before actually do the upgrade here.