Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kf5bluezqt] Update to 5.112.0. JB#57391 #8

Merged
merged 1 commit into from Dec 15, 2023
Merged

[kf5bluezqt] Update to 5.112.0. JB#57391 #8

merged 1 commit into from Dec 15, 2023

Conversation

pvuorela
Copy link
Contributor

Some churn on the patches:

  • pkgconfig patch no longer needed, upstream has the functionality.
  • MediaTransport patch dropped. Upstream has it an implementation for that. Not 100% the same as we did, but close enough.
  • Rest reordered a bit to include more upstreamable ones first.
  • Small adjustments following upstream, avoid QWeakPointer::data() and Q_EMIT instead of emit, etc.
  • Reverting now more things that need new qt. Most peculiar the one reverting minimum cmake version bump which broke the build here by duplicate symbols on .o files. Could be related to our Qt version(?)

Dropped the remaining bluez4 conflicts. That should be gone everywhere by now.

@pvuorela
Copy link
Contributor Author

Ah damn. Had few upstream changes here I hadn't fetched. Will check.

Some churn on the patches:
- pkgconfig patch no longer needed, upstream has the functionality.
- MediaTransport patch dropped. Upstream has it an implementation for that.
Not 100% the same as we did, but close enough.
- Rest reordered a bit to include more upstreamable ones first.
- Small adjustments following upstream, avoid QWeakPointer::data() and
Q_EMIT instead of emit, etc.
- Reverting now more things that need new qt. Most peculiar the one
reverting minimum cmake version bump which broke the build here by
duplicate symbols on .o files. Could be related to our Qt version(?)

Dropped the remaining bluez4 conflicts. That should be gone everywhere
by now.
@pvuorela
Copy link
Contributor Author

Phew, now applies cleanly and includes the local patching I missed earlier.

@pvuorela pvuorela merged commit 6173569 into master Dec 15, 2023
@mlehtima mlehtima deleted the update_5112 branch December 15, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants