[libcommhistory] Remove unneeded and incorrect service name references. JB#62154 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. JB#62154 Commhistoryd is having its own service name which is not this. There should be nothing using it generally. A few places were mistaking service and interface names, though the actual strings are the same.
|
That is a sensible change. There is no service here provided by a central object. |
mlehtima
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commhistoryd is having its own service name which is not this. There should be nothing using it generally. A few places were mistaking service and interface names, though the actual strings are the same.
Spotted while checking @dcaliste's dbus PRs.