Add checks for not repeating actions, clean debug #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaakkonenJussi
force-pushed
the
jb61555
branch
from
fc70b07
to
c25a489
Compare
LaakkonenJussi
changed the title
mlehtima
approved these changes
Feb 19, 2024
…es JB#61555 Do the default route update when there are changes in the service cache. This prevents doing unnecessary list traversals when there are no updates or when the default route is kept as the same. Also drop out from the services cache traversal when first not connected service is encountered since the service states are used for the ordered list originating from ConnMan. And cleanup some old debug to make output more clear. Drop excess call to updateDefaultRoute() - called in updateServices().
LaakkonenJussi
force-pushed
the
jb61555
branch
from
a9d7443
to
fb8f6d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the default route update only when there are changes in the service cache. This prevents doing unnecessary list traversals when there are no updates or when the default route is kept as the same.
Also drop out from the services cache traversal when first not connected service is encountered since the service states are used for the ordered list originating from ConnMan.
And cleanup some old debug to make output more clear.