[connman-qt5] Don't print deprecation warning on local access. JB#61909 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiiroin
approved these changes
Apr 17, 2024
The NetworkService::stateChanged() is still present and when it gets emitted, the macro setup ends up calling state() to get the signal parameter. Took the easy route, instead of rewriting the macro system etc just store when the signals are emitted and avoid the deprecation warning then.
pvuorela
force-pushed
the
bad_deprecation_warning
branch
from
d8ff515
to
d65eb21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NetworkService::stateChanged() is still present and when it gets emitted, the macro setup ends up calling state() to get the signal parameter.
Took the easy route, instead of rewriting the macro system etc just store when the signals are emitted and avoid the deprecation warning then.