Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Define and use MAKE var instead of explicitly calling make #5

Merged
merged 1 commit into from Sep 5, 2023

Conversation

JamiKettunen
Copy link
Contributor

There are multiple make implementations and nothing guarantees that the make executable is gmake, which is what this Makefile requires.

As a practical example https://chimera-linux.org/ uses bmake as the default make while also having gmake easily available for projects needing it.

My packaging of this project where this is used: JamiKettunen/cports@db1b003f

There are multiple make implementations and nothing guarantees that the
make executable is gmake, which is what this Makefile requires.
Copy link

@spiiroin spiiroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is = how gmake documentation suggest recursive builds should be done.

@monich monich merged commit 3f3eac8 into sailfishos:master Sep 5, 2023
@monich
Copy link
Member

monich commented Sep 5, 2023

Thanks!

@Thaodan
Copy link

Thaodan commented Sep 8, 2023

To late but defining make was redundant:
Make = make is part of IEEE Std 1003.1-2017 section Default Rules subsection Macros.

Also GNU make explains that $(MAKE) should always be used read:
https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants