[mlocale] Avoid broken MLocale::localeScripts() code and adjust tests. JB#52793 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomin1
reviewed
Feb 14, 2022
spiiroin
approved these changes
Feb 14, 2022
…. JB#52793 The locale script data seems removed from ICU in 2015 so we need a reimplementation if there's any need for the method. The method could be beneficial if there's wider use for the library so made it just warns instead of total removal. But at the moment the usage is quite thin in Sailfish side. On non-ICU build this was defining the method but didn't have an implementation. Made the method consistently defined now. Disabled some related testing in ft_locales. On testing side, also disabled @pinyinsearch collation which didn't work and for which I didn't find any definitions. Using that in real code would be making quite specific expectations as it's not included in any documentation. kk_Cyrl_KZ existence test removed. Deleted from ICU in 2015 CLDR 28 integration.
pvuorela
force-pushed
the
avoid_nonexisting_data
branch
from
1de9feb
to
ce5b4ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locale script data seems removed from ICU in 2015 so
we need a reimplementation if there's any need for the method.
The method could be beneficial if there's wider use for the library
so made it just warns instead of total removal. But at the moment
the usage is quite thin in Sailfish side.
On non-ICU build this was defining the method but didn't have
an implementation. Made the method consistently defined now.
Disabled some related testing in ft_locales.
On testing side, also disabled @pinyinsearch collation which
didn't work and for which I didn't find any definitions.
Using that in real code would be making quite specific expectations
as it's not included in any documentation.
kk_Cyrl_KZ existence test removed. Deleted from ICU in 2015 CLDR 28
integration.
@Tomin1 @spiiroin