Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor adjustments #21

Merged
merged 2 commits into from Dec 22, 2023
Merged

Minor adjustments #21

merged 2 commits into from Dec 22, 2023

Conversation

pvuorela
Copy link
Contributor

Some drive-by adjustments while testing qofono/ofono related bug. Two commits, one adjusting stylistic details and avoiding unnecessary null checks on new&delete, and one commit for adding some context when printing out d-bus errors.

@pvuorela
Cosmetics
474c8e3 
- By convention operators go to beginning of lines.
- Moving initializer lists to their own lines to help
readability.
- Removed unnecessary null checks on 'new' and 'delete'. 'new'
never returns null and delete on null is fine.
@pvuorela
[libqofono] Print D-Bus call failures with some context. JB#45628
00e42cb 
Just printing out error string from remote end could look strange
in journal, and reference to failed operation should help debuggin.
@pvuorela pvuorela merged commit 4d41aed into master Dec 22, 2023
@mlehtima mlehtima deleted the minor_adjustments branch April 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlehtima mlehtima mlehtima approved these changes

@spiiroin spiiroin Awaiting requested review from spiiroin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pvuorela @mlehtima