Migrate to Tracker3. JB#53910 OMP#JOLLA-60 #1
Conversation
Still qt4, let's just remove.
The binding part has slight behavior change, but suppose that's how it was meant to be.
Maybe made more sense when the code supported Qt4 and Qt5, but now it's just wrappers for plain single method calls.
Marked as TODO for removed and not used for anything. Let's just remove already.
Just extra confusion when the test files don't build and the feature is left out.
Just a few example apps, let's just skip building those.
…B#53910 OMP#JOLLA-60
…9 OMP#JOLLA-74 For now supported by the tracker_direct driver, though even that now skips the name as upstream clarified it's not needed for dbus based connection. Leaving anyway here as this might change. Related https://gitlab.gnome.org/GNOME/tracker/-/issues/303
| iteration \ | ||
| asynctracker \ | ||
| contacts | ||
|
|
||
| # QWidget based examples disabled for now: |
There was a problem hiding this comment.
You could put these inside a qtHaveModule(widgets) { } type condition which would prevent them being built in OBS where the module wouldn't be installed without it being added to dependencies. But then they would be built in an SDK that happened to have them installed and then you'd get errors because they're not packaged.
I don't know if there's value in packaging examples at all. The entire examples directory could easily be excluded.
There was a problem hiding this comment.
To be honest I'm not sure do any of the examples even work properly here. Some have been looking for contacts which weren't there even before(?), some are using the plain tracker plugin (not tracker_direct) which doesn't work anymore. Some even doing some hard-coded tracker1 d-bus.
Could be an option just to delete everything here, dunno.
| @@ -376,13 +376,13 @@ QString QSparqlBinding::toString() const | |||
| { | |||
| quoted = true; | |||
| QDateTime dt = val.toDateTime(); | |||
| int offset = dt.utcOffset(); | |||
| int offset = dt.offsetFromUtc(); | |||
There was a problem hiding this comment.
Any idea why QDateTime::toString(Qt::ISODate) isn't used?
There was a problem hiding this comment.
Maybe https://bugreports.qt.io/browse/QTBUG-26161 but not sure. See JB#52684#c7 for similar case perhaps.
There was a problem hiding this comment.
No idea, was here just changing a deprecated method to its replacement which it was already calling internally.
A bit confusing on the naming, but this was a version directly on top of d-bus without using any tracker libraries. Doesn't work anymore with Tracker3 so let's just remove it.
|
Added a commit to just remove the plain "tracker" plugin which was implemented on top of qdbus with tracker1 api. |
Recreated https://git.sailfishos.org/mer-core/libqtsparql/merge_requests/10
cc @okodron