Disable qml, fix tests. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed env variable for old tracker. Now it's all d-bus connections so need to make sure the whole d-bus session bus is inaccessible.
Would have needed some migration away from removedQTRACKER backend, and virtuoso we don't have. But generally not sure how much this even tests anything but qt threading and signal/slot connections.
spiiroin
approved these changes
Feb 14, 2022
To my knowledge nothing has ever used these, and thinking the whole feature could be revisited before adding any new usage. In addition the qml options usage from c++ was strange. Appearing to do that only to get one string for the driver name, perhaps also a hint that all this could be revisited. So let's just disable qml side for now.
…B#57284 These rely on removed QTRACKER banckend, need sparql queries updated to Tracker 3.x style explicit graph. Etc.
pvuorela
force-pushed
the
disable_qml_fix_tests
branch
from
6d65b37
to
ecf29cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits. One test fixed, one removed, all qml related disabled for now, three tests just disabled until they get halfway rewritten.
@Tomin1 @spiiroin