Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Document build time dependencies when utilising sailfishapp_i18n #46

Closed
Olf0 opened this issue Feb 24, 2024 · 0 comments · Fixed by #47
Closed

[Bug] Document build time dependencies when utilising sailfishapp_i18n #46

Olf0 opened this issue Feb 24, 2024 · 0 comments · Fixed by #47

Comments

@Olf0
Copy link

Olf0 commented Feb 24, 2024

Please let libsailfishapp-devel depend on qt5-qttools-linguist by a Requires: qt5-qttools-linguist in libsailfishapp's spec file, see PR #47.

Alternatively denote in the documentation for libsailfishapp, that if CONFIG += sailfishapp_i18n is specified in a .pro-file, also BuildRequires: qt5-qttools-linguist must be specified to satisfy the build time dependencies.
But the first suggestion (to add a corresponding dependency) would be much easier for developers, as they simply do not have to care, think and remember about this.

P.S.: This not being documented did cost me hours of research and tests! Later on I discovered, that others must have also performed this research already, e.g. Petr Tsymbarovich (mentaljam / osetr) for SailfishOS:Chum-GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant