Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2.3.0 #6

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Update to 2.3.0 #6

merged 1 commit into from
Jun 10, 2024

Conversation

mlehtima
Copy link
Contributor

Backport fix for building with gcc 12 or newer.
Remove not needed defattr.
Use cmake macros in build.

@mlehtima mlehtima requested a review from pvuorela June 10, 2024 14:54
Backport fix for building with gcc 12 or newer.
Remove not needed defattr.
Use cmake macros in build.
@mlehtima mlehtima changed the title [maliit] Update to 2.3.0. JB#62210 Update to 2.3.0 Jun 10, 2024
Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one new patch could also just be checkout bumped to include the change. Effectively the same but less hassle. But i'll just approve already, good in either form.

@mlehtima
Copy link
Contributor Author

I was also thinking if I should bump to latest master branch or just pick the needed change as branch and went with patch. I can do either way.

@mlehtima mlehtima merged commit 50ea28b into master Jun 10, 2024
@mlehtima mlehtima deleted the jb62210 branch June 10, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants