Fix build on Musl libc systems #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureTryOut
commented
Jun 18, 2021
When we include libgen.h, POSIX's basename will be used rather than GNU's. Since we don't use the special functionalities of GNU's variant anyway, this helps to compile it on POSIX-compliant libc's like Musl. https://www.man7.org/linux/man-pages/man3/basename.3.html
We link (in a proper CMake way) later a bit below this line, and that actually works on systems using e.g. elogind too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we use the POSIX basename rather than GNU's.
When we include libgen.h, POSIX's basename will be used rather than
GNU's. Since we don't use the special functionalities of GNU's variant
anyway, this helps to compile it on POSIX-compliant libc's like Musl.
Don't link to systemd twice.
We link (in a proper CMake way) later a bit below this line, and that
actually works on systems using e.g. elogind too.