[messagingframework] Sync upstream and fix compiler warnings on patches. JB#46713 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es. JB#46713 Upstream got one patch in. Rest of the patches adjusted to avoid compiler warnings mostly by sprinkling QLatin1String() here and there.
|
Patches apply well and the code compiles almost without any warning anymore. Nice. Actually there is one place in No problem to get this in with regards to my current changes and work. So good for me to go in. |
|
Yep, indeed that warning from upstream, thus not touched here. Also one unused variable warning on upstream unit test. I think the warnings introduced by the patches here should be handled now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream got one patch in.
Rest of the patches adjusted to avoid compiler warnings mostly by sprinkling QLatin1String() here and there.
@dcaliste - hope this doesn't conflict with any adjustments you've been doing too much. Got myself tired of seeing the warnings flood when trying different changes upstream.