Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[messagingframework] Separate account and SSO patch into two. #11

Merged
merged 1 commit into from Nov 27, 2023

Conversation

dcaliste
Copy link
Contributor

Update to latest master and seperate the
account + SSO patch into two pieces:

  • one patch using libaccounts-qt as a storage for QMailAccount objects,
  • one patch using libsignon-qt5 to get access to credentials for authentication.

@pvuorela it's an attempt to rework patches due to latest upstream changes. I'm going to test it on device before removing the WIP tag. By taking into account the upstream changes to handle SMTP 504, two phase authentication… I'm proposing to separate the old 0003-qt-integration.patch into two. It will then be easier to update the SSO only part and simplify it bit by bit, first by saving (in-memory) sso username/password in service configuration objects which will avoid having to change the IMAP/POP/SMTP APIs. And then, by generalising the ssoauth plugin into a credential plugin that could be accepted upstream, and just keeping here an SSO implementation for such plugin. Ideally, such credential plugin may even be used for exotic authentication mechanism like the one for EAS ?…

@pvuorela
Copy link
Contributor

A couple quick comments before going to the change details.

  • please use --no-signature when creating the patches so we don't get noise on the patches when they get created with different git versions.
  • While at it, there could be some chances of also merging a couple commits. E.g. "Introduce QMailAccount::HasPersistentConnection status flag" no longer introduces the flag and has only some parts for adjusting accounts/sso integration. Could be included in those commits? And Set-qmf-accountscheck-to-be-run-by-the-booster could be merged to the basic booster patch. Or both in the "Start-messageserver-on-system-startup". Some other changes also feel like fixing problems in earlier commits etc. But this just how much you feel like including extra patch changes.

@dcaliste dcaliste changed the title WIP: [messagingframework] Separate account and SSO patch into two. [messagingframework] Separate account and SSO patch into two. Nov 27, 2023
@dcaliste
Copy link
Contributor Author

I've removed the WIP tag. I've been using since last week, without noticing any issues. As you mentioned, I've also merged some of the iterating patches.

Update to latest master and seperate the
account + SSO patch into two pieces:
- one patch using libaccounts-qt as a storage
  for QMailAccount objects,
- one patch using libsignon-qt5 to get access
  to credentials for authentication.
@pvuorela pvuorela merged commit c8552c1 into sailfishos:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants