[messagingframework] Separate account and SSO patch into two. #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest master and seperate the
account + SSO patch into two pieces:
@pvuorela it's an attempt to rework patches due to latest upstream changes. I'm going to test it on device before removing the WIP tag. By taking into account the upstream changes to handle SMTP 504, two phase authentication… I'm proposing to separate the old 0003-qt-integration.patch into two. It will then be easier to update the SSO only part and simplify it bit by bit, first by saving (in-memory) sso username/password in service configuration objects which will avoid having to change the IMAP/POP/SMTP APIs. And then, by generalising the ssoauth plugin into a credential plugin that could be accepted upstream, and just keeping here an SSO implementation for such plugin. Ideally, such credential plugin may even be used for exotic authentication mechanism like the one for EAS ?…