Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nemo-connectivity] Use shared instance of NetworkManager. JB#61563 #10

Merged
merged 1 commit into from Apr 2, 2024

Conversation

pvuorela
Copy link
Contributor

Copy link
Contributor

@LaakkonenJussi LaakkonenJussi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaakkonenJussi
Copy link
Contributor

LaakkonenJussi commented Mar 28, 2024

That deprecation change seems to be a success in sailfishos/libconnman-qt#27 - this popped in the build.

connectionhelper.cpp:83:39: warning: ‘static NetworkManager* NetworkManagerFactory::createInstance()’ is deprecated: Use NetworkManager::sharedInstance() [-Wdeprecated-declarations]
   83 |     , m_netman(NetworkManagerFactory::createInstance())
      |                                       ^~~~~~~~~~~~~~
In file included from connectionhelper.cpp:48:
/usr/include/connman-qt5/networkmanager.h:29:88: note: declared here
   29 |     Q_DECL_DEPRECATED_X("Use NetworkManager::sharedInstance()") static NetworkManager* createInstance();
      |                                                                                        ^~~~~~~~~~~~~~

@pvuorela pvuorela merged commit b82a105 into master Apr 2, 2024
@pvuorela pvuorela deleted the shared_networkmanager branch April 2, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants