Fix requirements. JB#61688 #7
Conversation
pvuorela
force-pushed
the
fix_requirements
branch
from
34e712c
to
a45a126
Compare
|
Added commit for removing nemo-contacts dependency just to have one header (which shouldn't be in nemo-contacts), then doing some steps for skipping linkage to nemo-contacts and argh. In practice everyone else just copies the synchronizelists.h. |
So, we should make that thing, the synchronizelists.h a some kind of dev-header to be included via specific package making the header being included from some common location? |
That's a possibility, but let's do it separately. Could do a task for that. |
Why first do the hack and then the right solution? Creating a -devel package isn't witchcraft. |
Might it be more reasonable to do that in a separate task because it would require changes to many other places than this? I mean fix the dependencies in every package that uses a copy of this synchronizelists.h? Not to mix the garbage cleanup with it as their scope is different? |
Doing it properly gets first into question of introducing -devel package where? Answer is not nemo-qml-plugin-contacts as this is not really contacts specific and the file should be removed there. The same thing gets used here and there and we should not add contacts dependency to all of them. I don't even have an answer on where it should be, and my priority is now getting this library actually possible to be used. |
Suspect this was just copypasted somewhere. The installed header uses only qt things. And in addition to the unnecessary requirements this was actually missing the proper requirement for qml (QJSValue)
It's needed by diskusage.h so the c++ library cannot be used without it. And probably hasn't been used anywhere so far.
Requiring, linking, and then removing linkage to nemo-qml-plugin-contacts is silly when this only needs the synchronizelist.h which shouldn't be in contacts headers in the first place. Just do what every other project is doing already: include own copy.
pvuorela
force-pushed
the
fix_requirements
branch
from
a45a126
to
80dbf5f
Compare
OK makes sense. |
A bunch of garbage requirements on the .pc file. The filemanagerglobal.h is mandatory for building anything with the c++ library, so that side wasn't working at all.